Ticket #443 (closed defect: fixed)
Data rate units and statistics output format
| Reported by: | Radek Krejčí <krejci@…> | Owned by: | aturner |
|---|---|---|---|
| Priority: | medium | Milestone: | 3.4.5 |
| Component: | tcpreplay | Version: | 3.4.4 |
| Keywords: | Cc: | ||
| Operating System: | Add to FAQ?: | no | |
| Hardware: | All | ||
| Output of tcpreplay -V: | $ tcpreplay-3.4.4/src/tcpreplay -V tcpreplay version: 3.4.4 (build 15089M) Copyright 2000-2010 by Aaron Turner <aturner at synfin dot net> Cache file supported: 04 Not compiled with libdnet. Compiled against libpcap: 0.9.4 64 bit packet counters: enabled Verbose printing via tcpdump: enabled Packet editing: disabled Fragroute engine: disabled Injection method: pcap_inject() | ||
Description
Used data rate units (bps, Mbps, ) in statistics output (src/common/utils.c - packet_stats()) doesn't correspond to the computed values (values are in fact in Bps and Mibps - see http://en.wikipedia.org/wiki/Data_rate_units). I have prepared patch with the computation correctness, but I don't know where to post it :(
The second problem is in the same place - "Actual" and "Rated" lines are not separated by new line but only by \t\t since 3.4.4 version (actually since r2436 reffered by #424). This "feature" breaks statistics output on standard terminals (with 80 characters line width). Again I have patch applicable after the previous one.
Attachments
-
tcpreplay-3.4.4-stats.patch
(634 bytes) -
added by aturner 18 months ago.
-
tcpreplay-3.4.4-units.patch
(1.3 KB) -
added by aturner 18 months ago.
Change History
Note: See
TracTickets for help on using
tickets.
You can attach your patches to this ticket if you'd like.