Ticket #47 (closed task: fixed)

Opened 6 years ago

Last modified 5 years ago

General Code Clean Up

Reported by: aturner Owned by: aturner
Priority: medium Milestone: 3.0.0
Component: tcpreplay Version: 3.0.beta7
Keywords: Cc:
Operating System: Add to FAQ?: no
Hardware: All
Output of tcpreplay -V:

Description

Any commit which cleans up code.

Change History

comment:1 Changed 6 years ago by aturner

(In [1483]) cleanup and start using enum types and returning names rather then plain 0 or 1 refs #47

comment:2 Changed 6 years ago by aturner

(In [1485]) code cleanup. stop returning magic numbers and use names refs #47

comment:3 Changed 6 years ago by aturner

(In [1490]) code cleanup. improve binary<->string conversion for IPv4 refs #47, #26

comment:4 Changed 6 years ago by aturner

  • Status changed from new to assigned
  • Milestone changed from 3.0.beta8 to 3.0.0

comment:5 Changed 6 years ago by aturner

(In [1512]) ignore textmate project files refs #47

comment:6 Changed 6 years ago by aturner

(In [1514]) fix what we ship and stuff refs #47

comment:7 Changed 6 years ago by aturner

(In [1515]) fix log for rewrite_config refs #47

comment:8 Changed 6 years ago by aturner

(In [1524]) no need for these old man pages refs #47

comment:9 Changed 6 years ago by aturner

(In [1526]) remove libnids and add --enable-flowreplay and checks for pcap_inject() and pcap_sendpacket(). also lots of cleanup in the code refs #55, #47

comment:10 Changed 6 years ago by aturner

(In [1571]) move default values for minmask/maxmask from tree.h to the .def refs #47

comment:11 Changed 6 years ago by aturner

(In [1591]) svn:ignore *.pcap refs #47

comment:12 Changed 6 years ago by aturner

(In [1599]) remove need for pcap_next_ex() which is hard (impossible??) to re-impliment on my own. refs #80 Also some basic code cleanups. refs #47

comment:13 Changed 6 years ago by aturner

(In [1601]) cleanup get_name2addr4() a little refs #47

comment:14 Changed 6 years ago by aturner

(In [1604]) remove warnings, refs #47

comment:15 Changed 6 years ago by aturner

(In [1610]) minor tweaks to clean things up, refs #47

comment:16 Changed 5 years ago by aturner

(In [1633]) re-run autoheader. refs #47

comment:17 Changed 5 years ago by aturner

(In [1633]) re-run autoheader. refs #47

comment:18 Changed 5 years ago by aturner

(In [1633]) re-run autoheader. refs #47

comment:19 Changed 5 years ago by aturner

(In [1638]) add svn:keywords and fix copyright statements. refs #47

comment:20 Changed 5 years ago by aturner

(In [1639]) add svn:keywords and fix copyright statements. refs #47

comment:21 Changed 5 years ago by aturner

(In [1640]) add svn:keywords and fix copyright statements. refs #47

comment:22 Changed 5 years ago by aturner

(In [1641]) add svn:keywords and fix copyright statements. refs #47

comment:23 Changed 5 years ago by aturner

(In [1642]) add svn:keywords and fix copyright statements. refs #47

comment:24 Changed 5 years ago by aturner

(In [1643]) add svn:keywords and fix copyright statements. refs #47

comment:25 Changed 5 years ago by aturner

(In [1647]) new version based on new libopts & automake, refs #47, #97

comment:26 Changed 5 years ago by aturner

(In [1669]) add attribute((unused)) to various functions/args to suppress warnings refs #47

comment:27 Changed 5 years ago by aturner

(In [1672]) fix a crash found during test. Need to actually support dual pcap handles for #61. refs #47

comment:28 Changed 5 years ago by aturner

(In [1711]) small cleanup. refs #47

comment:30 Changed 5 years ago by aturner

(In [1721]) fix compile issue when users have two different copies of pcap.h installed on their system and not libpcapnav. (like my new box) refs #47

comment:31 Changed 5 years ago by aturner

(In [1722]) detect intel based Mac's and set the test nic approprately refs #47

comment:32 Changed 5 years ago by aturner

(In [1726]) remove reference to missing header and small cleanup. refs #47

comment:33 Changed 5 years ago by aturner

(In [1736]) don't warn on unused vars. refs #47

comment:34 Changed 5 years ago by aturner

(In [1738]) update w/ latest autoconf. refs #47

comment:35 Changed 5 years ago by aturner

(In [1739]) add asserts to find bugs earlier rather then later. refs #47

comment:36 Changed 5 years ago by aturner

(In [1743]) add missing headers to remove compile warnings. refs #47

comment:37 Changed 5 years ago by aturner

(In [1744]) fix svn:keywords. refs #47

comment:38 Changed 5 years ago by aturner

(In [1746]) fix svn:keywords. refs #47

comment:39 Changed 5 years ago by aturner

(In [1747]) fix svn:keywords. refs #47

comment:40 Changed 5 years ago by aturner

(In [1748]) fix svn:keywords. refs #47

comment:41 Changed 5 years ago by aturner

(In [1749]) fix svn:keywords. refs #47

comment:42 Changed 5 years ago by aturner

(In [1750]) fix compile warning. refs #47

comment:43 Changed 5 years ago by aturner

(In [1753]) fix svn:keywords. refs #47

comment:44 Changed 5 years ago by aturner

(In [1754]) libpcap changed how they install header files: pcap-bpf.h -> pcap/bpf.h so we need to find the file in the correct place. refs #47

comment:45 Changed 5 years ago by aturner

(In [1758]) add missing headers for clean compile. refs #47

comment:46 Changed 5 years ago by aturner

(In [1762]) remove svn:keyword and add keywords refs #47

comment:47 Changed 5 years ago by aturner

(In [1767]) return TCPEDIT_ERROR by default. refs #47

comment:48 Changed 5 years ago by aturner

(In [1769]) handle make test more gracefully for systems which we do not know the default nics refs #110, #47

comment:49 Changed 5 years ago by aturner

(In [1770]) call autoconf, automake, autoconf to bootstrap which seems like the "best" way. sigh. refs #47

comment:50 Changed 5 years ago by aturner

(In [1772]) update ignores. refs #47

comment:51 Changed 5 years ago by aturner

(In [1817]) stop annoying warning. refs #47

comment:52 Changed 5 years ago by aturner

(In [1818]) - warn OS X users about ticket #142

  • support CFLAGS environment for --enable-debug

refs #47

comment:53 Changed 5 years ago by aturner

(In [1819]) fix warning to actually fire. refs #47

comment:54 Changed 5 years ago by aturner

  • Add to FAQ? unset
  • Status changed from assigned to closed
  • Resolution set to fixed

comment:55 Changed 5 years ago by aturner

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:55 Changed 5 years ago by aturner

(In [1822]) use AC_MSG_RESULT when no bpf support. refs #47

comment:56 Changed 5 years ago by aturner

  • Status changed from reopened to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.